Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parachains: Use relay chain slot for velocity measurement #6825

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Dec 10, 2024

closes #3967

Changes

We now use relay chain slots to measure velocity on chain. Previously we were storing the current parachain slot. Then in on_state_proof of the ConsensusHook we were checking how many blocks were athored in the current parachain slot. This works well when the parachain slot time and relay chain slot time is the same. With elastic scaling, we can have parachain slot times lower than that of the relay chain. In these cases we want to measure velocity in relation to the relay chain. This PR adjusts that.

Migration

This PR includes a migration. Storage item SlotInfo of pallet aura-ext is renamed to RelaySlotInfo to better reflect its new content. A migration has been added that just kills the old storage item. RelaySlotInfo will be None initially but its value will be adjusted after one new relay chain slot arrives.

@skunert skunert added the T9-cumulus This PR/Issue is related to cumulus. label Dec 10, 2024
@skunert
Copy link
Contributor Author

skunert commented Dec 10, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 10, 2024

@skunert https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7892036 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 23-6352bad6-c9e1-4490-bf52-e6b6f707a5f3 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 10, 2024

@skunert Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7892036 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7892036/artifacts/download.

@skunert
Copy link
Contributor Author

skunert commented Dec 11, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Dec 11, 2024

@skunert https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7898854 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 26-f389b4df-c557-4572-a276-5937d6dc8d7d to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 11, 2024

@skunert Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7898854 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7898854/artifacts/download.

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12273395469
Failed job name: test-linux-stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T9-cumulus This PR/Issue is related to cumulus.
Projects
Status: backlog
Development

Successfully merging this pull request may close these issues.

slot-based-collator: Adjust ConsensusHook and parent search
1 participant