Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet-revive: disable host functions not in revive recompiler #6844

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

davidk-pt
Copy link
Contributor

Resolves #6720

List of used host functions in PolkaVM recompiler is here https://github.com/paritytech/revive/blob/main/crates/runtime-api/src/polkavm_imports.c#L65

@davidk-pt davidk-pt added the T7-smart_contracts This PR/Issue is related to smart contracts. label Dec 11, 2024
@davidk-pt davidk-pt requested review from athei and xermicus December 11, 2024 11:52
@davidk-pt davidk-pt changed the title Disable host functions not in revive recompiler pallet-contracts: disable host functions not in revive recompiler Dec 11, 2024
@athei
Copy link
Member

athei commented Dec 11, 2024

You submitted your diff against the wrong pallet :)

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12276786843
Failed job name: run-frame-omni-bencher

@davidk-pt davidk-pt changed the title pallet-contracts: disable host functions not in revive recompiler pallet-revive: disable host functions not in revive recompiler Dec 11, 2024
@davidk-pt
Copy link
Contributor Author

You submitted your diff against the wrong pallet :)

My bad, made change against pallet-revive now, thought this was about old contracts pallet

@davidk-pt davidk-pt marked this pull request as ready for review December 11, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable all host functions which are not needed for launch
2 participants