Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail series if the test fails on the base #110

Open
bonzini opened this issue Mar 14, 2019 · 3 comments
Open

Do not fail series if the test fails on the base #110

bonzini opened this issue Mar 14, 2019 · 3 comments

Comments

@bonzini
Copy link
Contributor

bonzini commented Mar 14, 2019

When a test is failing on master, currently it will end up failing on all submitted patches too. We should instead mark the results as BLOCKED rather than PENDING in the series; the test can be triggered manually on the series that fixes the breakage.

This way: 1) we can make the "T" icon yellow instead of red; 2) we don't inundate the mailing list with failures; 3) we can easily search the affected patches and retrigger testing on them (with "blocked:testing" as a search term).

@famz
Copy link
Collaborator

famz commented Mar 15, 2019

Related: #32

@famz
Copy link
Collaborator

famz commented Mar 15, 2019

If all series are still tested regardless of their base (master) failure, the "fix" for the base breakage can be verified without human involvement.

All that is required is to turn "errors" into "warnings" when failures are also seen on a series "base", I think.

@bonzini bonzini changed the title add BLOCKED state for results Do not fail series if the test fails on the base Mar 15, 2019
@bonzini
Copy link
Contributor Author

bonzini commented Mar 15, 2019

True. So another possibility is to add a base_status to the testing result data, and use it to distinguish error (red) from warning (yellow) in the dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants