Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patchew email reports should trim test output to a sane limit, perhaps 100 KB #124

Open
berrange opened this issue Jan 21, 2020 · 1 comment

Comments

@berrange
Copy link

berrange commented Jan 21, 2020

In some qemu-devel patches, the test output from patchew can be enourmous. For example

https://patchew.org/QEMU/[email protected]/

this resulted in me being sent a 1.2 MB email from patchew which is rather over the top. Only people directly cc'd on the mail received it, because the qemu-devel size limit caused it to be rejected from mailing list delivery. This means most people will never see the test failure.

Patchew should impose a cap on test output, trimming it to say the most recent 100 KB, so that the messages aren't overly huge and at risk of being rejected by mailing lists. If people want to see the full log they can use the web UI

@bonzini
Copy link
Contributor

bonzini commented Jan 21, 2020

It is already trimming the content to only the text around errors; that series is quite a special case, because it's so big and because it has a huge amount of new code that doesn't respect the QEMU coding standards. That said yeah, a global limit in mods/email.py should not be hard to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants