Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use django.contrib.messages for actions #140

Open
bonzini opened this issue Apr 6, 2022 · 1 comment
Open

use django.contrib.messages for actions #140

bonzini opened this issue Apr 6, 2022 · 1 comment
Labels
ui This issue affects the appearance of the Patchew website

Comments

@bonzini
Copy link
Contributor

bonzini commented Apr 6, 2022

There is currently almost no feedback for actions in the blue box on the right. We could use django.contrib.messages to show a little box in a corner, and fade it away one second after the page loads.

https://docs.djangoproject.com/en/4.0/ref/contrib/messages/

@bonzini bonzini added the ui This issue affects the appearance of the Patchew website label Apr 6, 2022
@bonzini
Copy link
Contributor Author

bonzini commented Apr 22, 2022

Before doing this it's probably best to update to Bootstrap 5 (the toast component had some changes between 4 and 5). The necessary changes are:

  • form-group was replaced by grid
  • card collapse could be replaced by accordion? check if it works
  • Navbars now require a container within
  • Renamed .ml-* and .mr-* to .ms-* and .me-*.
  • Data attributes for all JavaScript plugins are now namespaced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui This issue affects the appearance of the Patchew website
Projects
None yet
Development

No branches or pull requests

1 participant