Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass const-references to the save_*model() functions #244

Open
patrikhuber opened this issue Dec 31, 2018 · 0 comments
Open

Pass const-references to the save_*model() functions #244

patrikhuber opened this issue Dec 31, 2018 · 0 comments
Labels
enhancement

Comments

@patrikhuber
Copy link
Owner

patrikhuber commented Dec 31, 2018 •
edited
Loading

I think here

eos/include/eos/morphablemodel/PcaModel.hpp

Line 348 in f8b235b

inline void save_pca_model(PcaModel model, std::string filename)
and here

eos/include/eos/morphablemodel/MorphableModel.hpp

Line 546 in f8b235b

inline void save_model(MorphableModel model, std::string filename)
we could just pass const& model, otherwise we make a copy of the model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrikhuber