Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology - need guidance on responsive toolbars #56

Open
nicolethoen opened this issue Mar 14, 2023 · 0 comments
Open

topology - need guidance on responsive toolbars #56

nicolethoen opened this issue Mar 14, 2023 · 0 comments

Comments

@nicolethoen
Copy link
Contributor

nicolethoen commented Mar 14, 2023

Topology's TopologyView.tsx creates a Toolbar component and simply provides props for the consumer to define the items to place in the toolbar (via the contextToolbar and the viewToolbar).

In consumers simple began packing ToolbarItems into these props, then they could end up with an unresponsive Toolbar, which would wrap weirdly.

More guidance should be provided for how to use the props in the TopologyView to create a responsive toolbar - especially with ToolbarToggleGroups and OverflowMenus.

Currently, Dev Sandbox has a topology toolbar which appears the following way on mobile views:

IMG_2476

Additionally, I don't know if people are wanting to see a ToolbarFilter on their Topology toolbars, which would display applied filters as chips below the Toolbar controls. If so, guidance or even an update to the Topology view might be needed.

@jessiehuff jessiehuff transferred this issue from patternfly/patternfly-infra-issues May 24, 2023
@jessiehuff jessiehuff moved this from Needs triage to Not started in PatternFly Extensions May 24, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Mar 29, 2024
@dlabaj dlabaj moved this from Needs triage to Backlog in PatternFly Issues Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants