Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling the Results returned by consume() #10

Open
wysiwys opened this issue Dec 20, 2024 · 0 comments
Open

Handling the Results returned by consume() #10

wysiwys opened this issue Dec 20, 2024 · 0 comments

Comments

@wysiwys
Copy link

wysiwys commented Dec 20, 2024

Hi fax maintainers,

Thanks for all your work on this crate.

In the implementation of Entry::find() in maps.rs, there are some calls to reader.consume(len) where the Result returned is not handled. Currently, this leads to some Rust compiler warnings being generated. Is the intended behavior to skip handling these Results?

If it would be helpful, I can go ahead and make a PR that makes this behavior explicit, or instead make one with some additional error handling for these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant