Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not report trailing commas as JSON errors #10

Open
shdwcat opened this issue Jul 13, 2022 · 2 comments
Open

Does not report trailing commas as JSON errors #10

shdwcat opened this issue Jul 13, 2022 · 2 comments

Comments

@shdwcat
Copy link

shdwcat commented Jul 13, 2022

For example, this chunk of JSON is not valid:

	"patterns": [
		{
			"include": "#keywords"
		},
		{
			"include": "#strings"
		}, <-- this comma is an error in standard JSON
	],

It's very easy to miss these and VS Code will not load the language file if errors like this are present.

@pedro-w
Copy link
Owner

pedro-w commented Jul 19, 2022

Apologies for the delay, I will look into it.

@pedro-w
Copy link
Owner

pedro-w commented Sep 6, 2022

Actually I don't know how to do this. I put a bounty on an unanswered question on StackOverflow - it didn't help much but it looks like maybe I have to add a JSON parser as a dependency and make use of that. Which seems weird that I can't make use of the JSON support that VSCode already has built-in. In other words I just want the tmlanguage to be an add-in to JSON editing, not replace it entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants