Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual partitioning is broken #42

Open
Wuodan opened this issue Aug 6, 2018 · 1 comment
Open

Manual partitioning is broken #42

Wuodan opened this issue Aug 6, 2018 · 1 comment

Comments

@Wuodan
Copy link
Contributor

Wuodan commented Aug 6, 2018

In the partitioning sub-menu, select the 2nd option "Manually partition ..."
The output of the partitioning tool (cfdisk or cgdisk) ends up in the log file /tmp/pentoo-installer.log

The 'source' of the problem seems to be in sbin/pentoo-installer:

2> /tmp/pentoo-installer.log

if I remove that and remove redirection where cgdisk is called, then cgdisk starts working. But having no log file is no option!

My options:

  • replace that 2>log-file with tee
    Some scary process substitution and file redirection and cgdisk shows, but output is slightly borken and keyboard input does not work.

  • Find out why vim/nano work in system config ... if they do, cgdisk should too.

  • Drop support for manual partitioning.
    Seriously, anyone doing that should be able to do it outside installer. Plus cgdisk/cfdisk are the last tools I would use, only reason I kept them in the installer is cause i thought 'parted' was to complicated. But parted does not work for the same reason.

  • Let user edit some json config that I'm preparing to have installer run form config-file ... don't think we want that either.

@Wuodan
Copy link
Contributor Author

Wuodan commented Aug 6, 2018

Without all the:
CONFIG_LIST="$(script)"
that lead to the partition_manual file (2), it works.
But that's the way installer was designed, write CONFIG_LIST to STDOUT, not to a file.
Reason: that list may contain sensitive info to remount partitions.

==> we could move that manual partitioning part to main-menu, then it does not need to return anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants