-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Like console routing, need an ability for following protocols TCPIP, HTTP, gRPC routing #44
Comments
Thanks @Nilavarasi-Ashika, for reporting an issue. This is an enhancement request. Can you explain at a high level why you cannot implement a custom Http and gRPC routing service at your end? Our framework already supports custom routing services. We already have TCP/IP routing service by default. |
@Nilavarasi-Ashika: We support UDP terminal router. Please validate and let us know your feedback. The UDP feature will be released with version 5.10.x |
Please let us know when gRPC support will be available. /// The terminal starts as a gRPC server that listens to an incoming message. NOT YET SUPPORTED. /// Grpc = 3, |
@Nilavarasi-Ashika, we have started a discussion thread to integrate gRPC within terminal framework. We can provide an intermediate implementation with Grpc.Core but this package is due deprecation. |
@Nilavarasi-Ashika : We now have the gRPC implementation using the latest recommended approach grpc/grpc-dotnet#2543. This does not use the old Grpc.Core instead using AspNet.Core hosting. Please use the latest code in main branch and provide us feedback from your usage. We plan to release a Nuget package for 5.13.x by Oct-2024 end. To see the sample gRPC integration with terminal framework see https://github.com/perpetualintelligence/terminal/tree/main/apps/s2s |
@Nilavarasi-Ashika: Both gRPC and HTTP terminal routing as servers are now supported. We have added the following new packages: OneImlx.Terminal --> Main Terminal framework package As mentioned earlier we are targeting release on Oct-end please validate and let us know feedback, |
In Http protocol routing the response from server to client not performing. while verified in the code TerminalHttpAppExtensions MapTerminalHttp not returning response message with data to client, it just performing command routing. |
@Nilavarasi-Ashika: The syntax and naming of the API have changed, please verify the updated code for your use case. We are still reviewing your request for response handling. @prawasu please review this request. |
In TerminalConsoleRouter RunAsync method passing null for CommandRunnerContext.HandlerContext.RouterContext.Properites to ProcessAsync method inside the class CommandRunnerResultSendToFile. |
@Nilavarasi-Ashika: Fixed it there was an issue with sample app. Please check. We are working on the response handling as well. |
Please review the following issues observed in the latest code:
|
@Nilavarasi-Ashika: We are working on providing a mechanism for asynchronous response handling along with gRPC and Http support. But this will be a breaking change. We have moved this to Nov end milestone. Please keep tracking the result branch for result and provide your feedback for testing. |
@Nilavarasi-Ashika: The response handling is implemented in the the result branch. Note these are breaking changes. Please fully test your application scenarios and give us feedback. We plan to release nuget packages by end of Nov. |
Verified result branch code and encounter below issues;
|
@Nilavarasi-Ashika: Did you check our Sample App on how to use TCP with Streaming and Response handling. Http and gRPC are command and response protocols while TCP sends a stream of bytes so its response handling is separate. Are you using UDP in your application to send and receive the response as well ? |
we are verified with TCP, gRPC and http. For all network type routing the command and response handling working as expected. |
@Nilavarasi-Ashika: Thanks for your feedback. We have intentionally disabled the response handling for UDP (since it is fire and forget protocol). We will investigate and get back to you. Please note that we have moved the release for this issue to Dec-2024. |
@Nilavarasi-Ashika: We have published the preview 6.x.x. packages. Please verify and let us know testing feedback based on your application use. Note we are still working on UDP result processing. |
Is your feature request related to a problem? Please describe.
Like console mode routing, we need the routing feature for these protocols TCPIP, HTTP, gRPC.
Runtime
OS: Linux
.NET 7.0.2
pi-cli 4.2.4-rc
The text was updated successfully, but these errors were encountered: