Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed services are removed from the ldb results if the time is after the scheduled departure time #26

Open
peter-mount opened this issue Sep 17, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@peter-mount
Copy link
Owner

For this one if a service has been delayed but the current time is after the scheduled departure time then the service disappears.

For example just now I saw at LBG a service scheduled for 19:15 but was expected at 19:21. At 19:16 it disappeared off the boards.

I've already looked at this and the problem is that in LDB we store the services by the departure time, so when we look for departures at a station then it logically skips that one as it's outside of the search range.

This one will be tricky as we can either:

  1. keep the key as it was but look at the current forecast to see if it should be included
  2. change the key to match the forecast

The second option is not a good idea as it could end up corrupting the cache but the first option has the problem of how far back in time do we look.

This needs further thought

@peter-mount peter-mount added the bug Something isn't working label Sep 17, 2019
@peter-mount peter-mount self-assigned this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant