Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pass the exception" in the middleware #1

Open
petterroea opened this issue Mar 23, 2020 · 0 comments
Open

"Pass the exception" in the middleware #1

petterroea opened this issue Mar 23, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@petterroea
Copy link
Owner

petterroea commented Mar 23, 2020

In theory, express will never learn of any exceptions due to this middleware catching it. Should probably re-throw it.

Place of interest: https://github.com/petterroea/express-debug-toolbar/blob/master/app/index.ts#L63

@petterroea petterroea added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant