-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid index buffer type #47
Comments
Why do we support cmd.indices.type at all? Is this for gltf where shared subbuffer has to be reinterpreted as index data? The problematic code in pex-renderer is here As just using typed array keeps old Uint16 type still set.] g.cells = new Uint32Array(flatten(g.cells)) This can can be solved by g.cells = { data: new Uint32Array(flatten(g.cells)), type: graph.ctx.DataType.Uint32 } |
|
So this is more tricky because in Index element arrays and attrib buffers do That's why i duplicate type in both buffer and attribute. |
When using pex-renderer with uint32 the indices type was uint16 while cmd.indices.buffer.type was uint32 which causes glitches in rendering.
https://github.com/pex-gl/pex-context/blob/master/index.js#L761
Test code. Is it because we are updating geometry?
The text was updated successfully, but these errors were encountered: