Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the phi(m) function. #470

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix the phi(m) function. #470

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
613fef8
Fix the phi(m) function.
rdrehmel Feb 13, 2024
8132796
Make phi(m) look nicer.
rdrehmel Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/latex/pgfplots/pgfplots.reference.markers-meta.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3918,7 +3918,7 @@ \subsection{User Input Format for Point Meta}
a function
\[ \phi\colon [m_{\min},m_{\max}] \to [0,1000] \]
with
\[ \phi(m) = \frac{m - m_{\min}} {1000} \]
\[ \phi(m) = \frac{m - m_{\min}}{m_{\max} - m_{\min}} \cdot 1000 \]
Comment on lines 3919 to +3921
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace \min and \max with \text{min} and \text{max}, respectively.

@Mo-Gul What's your opinion? I saw the \min and \max was used by you in c1f06d2,
c1f06d2#diff-6e962382adf5c2d217286bdc2b2c609882e7401ed126f5d7fecf61f550e1f9ba.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muzimuzhi, why shouldn't we use the predefined mathematical functions \min and \max?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was afraid the extra treatments for mathematical functions (i.e. wrapping in \mathop) would interfere the spacing. I checked and it seems using \min/\max solely in subscripts gave the same spacing as \text{min}/\text{max}.

Not a big deal.

such that $\phi(m_{\min}) = 0$ and $\phi(m_{\max})=1000$. The value $1000$
is -- per convention -- the upper limit of all color maps. Now, if a
coordinate (or edge/face) has the point meta data $m$, its color will be
Expand Down
Loading