-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune Grunt tasks #1461
Comments
Much of this issue should probably wait until we finish discussing phetsims/perennial#370. |
Good work for this issue is being done over in phetsims/perennial#370. Take this issue off hold once that issue is closed. |
Ready to focus on the TODOs for this issue. |
Most of these are now just the "ASK DEVS" TODOs. |
I made a form to ask devs about the items we have marked with TODOs. I'll send it out now. https://docs.google.com/forms/d/1IXJCC33lyDIfDly0rFVsPAIWADkpKztM0NWH4umgfXg/edit |
Alright. With 8 responses, here are the results: KEEP: DELETE: |
print-shas.sh#!/bin/bash
#=======================================================================================
#
# Prints shas for all repos in the working directory.
#
# Author: Chris Malley (PixelZoom, Inc.)
#
#=======================================================================================
binDir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
workingDir=${binDir}/../..
cd ${workingDir}
for repo in `ls -1`
do
# Strip newline from end of repo
repo=`echo ${repo}`
# if it's a Git repository...
if [ -d ${repo}/.git ]; then
cd ${repo} > /dev/null
# format is "{{repo}} {{sha}}"
echo "${repo} `git rev-parse HEAD`"
cd .. > /dev/null
fi
done |
Alright I think we are pretty close here. From the survey, a couple things to check in on:
@jbphet please feel free to close this issue if you just want to keep |
@zepumph - I'm all for keeping things tidy, so please go ahead and delete |
Excellent, and thank you for your flexibility. Last TODO removed above. Closing |
Discovered in #1459, there are many tasks in chipper's Gruntfile.js or perennial's Gruntfile.js that:
@zepumph and I recommend reviewing each grunt task to see if it can be deleted or moved to a separately executable script. Things that should remain are: simulation lifecycle events like
grunt --brands=phet
grunt dev
grunt rc
grunt lint
and their dependencies. And for tasks that must remain stable, well-supported, and backward-compatible for maintenance tasks.This work will help us modularize & limit our usage of grunt, which we would like to "abandon" #1436
It will also free us up to use other runtimes (such as deno or tsx) or TypeScript as desired.
I will tag suspicious grunt tasks, then bring to Monday's developer meeting. I will make annotations in perennial/main and chipper's typescript_chipper_1459_b branch. (and they can (mostly?) be seen below)
The text was updated successfully, but these errors were encountered: