Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint bug in release-branches/ #400

Open
zepumph opened this issue Jul 9, 2024 · 4 comments
Open

lint bug in release-branches/ #400

zepumph opened this issue Jul 9, 2024 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jul 9, 2024

While @jonathanolson was working on the MR for phetsims/scenery#1643, linting hookes-law 1.1 (unpublished) failed with this error:

Running "lint-all" task
[........................................] 100.00%


/Users/jon/phet/git/release-branches/hookes-law-1.1/chipper/js/grunt/typescript-test.ts
  0:0  error  Parsing error: ESLint was configured to run on `<tsconfigRootDir>/js/grunt/typescript-test.ts` using `parserOptions.project`: /users/jon/phet/git/release-branches/hookes-law-1.1/chipper/tsconfig/all/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file

✖ 1 problem (1 error, 0 warnings)


Fatal error: Lint failed

We cannot reproduce on main, and we cannot reproduce with grunt checkout-target --target=1.1 --repo=hookes-law, so we are thinking it has something to do with the release inside the release-branches/ directory.

@zepumph
Copy link
Member Author

zepumph commented Jul 9, 2024

This should block the creation of a release branch, at least until speaking to @samreid or @zepumph.

@zepumph
Copy link
Member Author

zepumph commented Jul 9, 2024

Ok. This fixes the issue, but we never really got to the bottom of why this isn't reproducible on main.

@samreid mentioned we may want to try to upgrade out lint and typescript packages to see if that helps.

@zepumph
Copy link
Member Author

zepumph commented Jul 9, 2024

This is something to note when we start working on phetsims/chipper#1437 again.

@zepumph
Copy link
Member Author

zepumph commented Jul 18, 2024

Now that there is a workaround to unblock the MR, I'll unassign until we work on phetsims/chipper#1437

@zepumph zepumph removed their assignment Jul 18, 2024
@zepumph zepumph transferred this issue from phetsims/chipper Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant