-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create browser-and-node config #418
Comments
I was able to confirm that this is what the browser-and-node tsconfig file should be (none of the browser-specific or node-specific config entries should be combined).
|
I believe this is complete, but I'll come back once we complete phetsims/chipper#1483. |
Ok. I don't think there is anything else here. I'd like to check in with @samreid to see what else we may need to do for this one.
|
I'm a liar! We got the tsconfig stuff working well, but we still need to work out lint. For example. We want to make sure that
|
@zepumph and I reviewed and agreed we need a |
I think this is complete. @samreid can you think of anything else here? Feel free to close. |
Really great, nice work. Closing. |
From phetsims/chipper#1526 (comment), we have a collection of es modules that we are using in both sims and Node code:
I'm creating a side issue from phetsims/chipper#1526 (comment). I also want to put this on hold until we complete phetsims/chipper#1483
The text was updated successfully, but these errors were encountered: