Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: drop support for PHP < 7.2 in the 2.0 version #172

Open
jrfnl opened this issue Apr 23, 2024 · 1 comment
Open

Proposal: drop support for PHP < 7.2 in the 2.0 version #172

jrfnl opened this issue Apr 23, 2024 · 1 comment

Comments

@jrfnl
Copy link
Collaborator

jrfnl commented Apr 23, 2024

The 2.0 version will contain breaking changes, but only for integrators, i.e. people using the classes in the package directly.

For end-users we currently don't expect any breaking changes, so end-users which would need to still run PHP Parallel Lint on older PHP versions could set up their Composer requirement as "php-parallel-lint/php-parallel-lint": "^1.0 || ^2.0".

PHP 7.2 has been out for 6/7 years now and a lot of projects have already dropped support for PHP < 7.2, so it seems reasonable, especially as users of older PHP versions can still use the 1.x range, for this tool to also drop support for PHP , 7.2.

It will allow for some modernization of the code base and making the code slightly more maintainable.

If anyone has any objections or concerns about this proposal, please speak up now.

@grogy
Copy link
Member

grogy commented Apr 25, 2024

I full agree with this issue.

For clarification - we are giving time until the end of May 2024 for any comments. Please discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants