When installed globally local autoloader is loaded

[szepeviktor]

$ parallel-lint --blame --exclude vendor/ .
PHP Fatal error:  Uncaught Error: Class 'JakubOnderka\PhpParallelLint\Application' not found in /home/viktor/.composer/vendor/php-parallel-lint/php-parallel-lint/parallel-lint:62
Stack trace:
#0 {main}
  thrown in /home/viktor/.composer/vendor/php-parallel-lint/php-parallel-lint/parallel-lint on line 62

[jrfnl]

Loosely related to #1 and #9

[grogy]

Info about solution a problem is on #2 (comment)

[szepeviktor]

Thank you.
Wouldn't it be nice if it would just work ©️ ?

[grogy]

I did something bad? I don't see you PR here or in previous repository.

[szepeviktor]

I did something bad?

No, not at all.

I don't see you PR here or in previous repository.

I'm not involved in the development.

[szepeviktor]

There must be popular packages/boilerplates for PHP CLI tools!

[mfn]

Same issue since I moved from the abandoned package (pre 1.0) to this one.

Problem is this order here

PHP-Parallel-Lint/parallel-lint

Lines 39 to 44 in de81f0a

	getcwd() . '/vendor/autoload.php',
	getcwd() . '/../../autoload.php',
	__DIR__ . '/vendor/autoload.php',
	__DIR__ . '/../vendor/autoload.php',
	__DIR__ . '/../../../autoload.php',
	__DIR__ . '/../../autoload.php',

If favours autoloading from the current execution directory.

To me this feels kind of odd, when I run the vendor/bin/parallel-int, it should always use the autoloader from within that installation directory (I installed it via composer).

I.e. I would propose this order instead:

$autoloadLocations = [
    __DIR__ . '/vendor/autoload.php',
    __DIR__ . '/../vendor/autoload.php',
    __DIR__ . '/../../../autoload.php',
    __DIR__ . '/../../autoload.php',
    getcwd() . '/vendor/autoload.php',
    getcwd() . '/../../autoload.php',
];

Not sure what scenarios would require (or even prefer) getwcwd anyway, maybe some out-of-composer manual installation approach?

Reason:

• I've an installation in ./app/Vendor (cakephp2, don't ask)
• running it from ./ which has another (different) composer installation
• 💥

Not a big issue likely, I'll work it around on my end somehow probably.

[grogy]

Thank you for your comment. I think about why is getcwd necessary.

Commit what added it:

• JakubOnderka/PHP-Parallel-Lint@f536d0d#diff-32f5d7dbf80a3aeafb22a44ccda60465R39
• previous state in same commit JakubOnderka/PHP-Parallel-Lint@f536d0d#diff-e8da784cc2ef56ee8ab5e2e633722216L73

I speculate about removing lines from code:

    getcwd() . '/vendor/autoload.php',
    getcwd() . '/../../autoload.php',

See here somebody a reason why let lines in codebase?

[szepeviktor]

Please reconsider using a CLI framework/boilerplate.

e.g. https://github.com/elliotjreed/php-cli-boilerplate
or https://github.com/laravel-zero/laravel-zero
https://github.com/splitbrain/php-cli

[mfn]

See here somebody a reason why let lines in codebase?

Not really, we would need to ask the original author.

If this package is supposed to run via composer, then I think it's safe to nuke them even.

Changing the order might be possible but if left in I would suggest to understand why; removal is easier 😄