Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #140

Closed
ruudk opened this issue Nov 27, 2024 · 2 comments · Fixed by #141
Closed

PHP 8.4 compatibility #140

ruudk opened this issue Nov 27, 2024 · 2 comments · Fixed by #141
Labels
bug Something isn't working

Comments

@ruudk
Copy link

ruudk commented Nov 27, 2024

It seems that the latest 0.2.0 as well as the nightly is not fully compatible with PHP 8.4 as it produces deprecation warnings:

$ php -v
PHP 8.4.1 (cli) (built: Nov 20 2024 09:48:35) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.4.1, Copyright (c) Zend Technologies
    with Zend OPcache v8.4.1, Copyright (c), by Zend Technologies
$ php pie-nightly.phar --version
Deprecated: Illuminate\Container\Container::beforeResolving(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in phar:///Volumes/CS/www/cosmos/pie-nightly.phar/vendor/illuminate/container/Container.php on line 1151

Deprecated: Illuminate\Container\Container::resolving(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in phar:///Volumes/CS/www/cosmos/pie-nightly.phar/vendor/illuminate/container/Container.php on line 1171

Deprecated: Illuminate\Container\Container::afterResolving(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in phar:///Volumes/CS/www/cosmos/pie-nightly.phar/vendor/illuminate/container/Container.php on line 1191

Deprecated: Illuminate\Container\Container::setInstance(): Implicitly marking parameter $container as nullable is deprecated, the explicit nullable type must be used instead in phar:///Volumes/CS/www/cosmos/pie-nightly.phar/vendor/illuminate/container/Container.php on line 1430

Deprecated: Illuminate\Contracts\Container\Container::beforeResolving(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in phar:///Volumes/CS/www/cosmos/pie-nightly.phar/vendor/illuminate/contracts/Container/Container.php on line 200

Deprecated: Illuminate\Contracts\Container\Container::resolving(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in phar:///Volumes/CS/www/cosmos/pie-nightly.phar/vendor/illuminate/contracts/Container/Container.php on line 209

Deprecated: Illuminate\Contracts\Container\Container::afterResolving(): Implicitly marking parameter $callback as nullable is deprecated, the explicit nullable type must be used instead in phar:///Volumes/CS/www/cosmos/pie-nightly.phar/vendor/illuminate/contracts/Container/Container.php on line 218
🥧 PHP Installer for Extensions (PIE) 0.2.0@3abe8f5
@asgrim asgrim added the bug Something isn't working label Nov 27, 2024
@asgrim
Copy link
Collaborator

asgrim commented Nov 27, 2024

Thanks for the info, will get investigated now :)

TimWolla added a commit to TimWolla/php-pie that referenced this issue Nov 27, 2024
This fixes the nullable parameter deprecation for PHP 8.4 and thus fixes
php#140.
@TimWolla
Copy link
Member

#141 should fix the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants