Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfiles #1

Closed
ehuggett opened this issue Sep 27, 2017 · 15 comments
Closed

Dockerfiles #1

ehuggett opened this issue Sep 27, 2017 · 15 comments

Comments

@ehuggett
Copy link

Can the Dockerfiles used to create the images hosted at https://hub.docker.com/u/phplist/ be included in this repository?

@samtuke
Copy link
Contributor

samtuke commented Sep 28, 2017

That's a good question for @michield

@michield
Copy link
Member

Those are on the internal branch in the gitlab mirror of the repo. I may publish them here later, but I've added you to the project. https://gitlab.com/phpList/phplist-docker/tree/internal

@ehuggett
Copy link
Author

ehuggett commented Oct 1, 2017

Thanks, I now have a phplist container based on your Dockerfile but using https://hub.docker.com/_/php/ as the base image (mainly just experimenting, but I might suggest some changes if I do anything useful).

@michield
Copy link
Member

michield commented Oct 1, 2017

Yes, of course, that would be great. Maybe branch or fork away first and then PR the changes.

@jryberg
Copy link

jryberg commented Oct 19, 2017

Hi,

I would like to have access to the Dockerfile as well and also permission to fork it.

Depending how much work there is to get it up and running I might be able to contribute

@michield
Copy link
Member

I'll try to spend some time to review them and make them ready for public viewing. As I recall, they're a bit messy at the moment :-)

@michield2
Copy link

Reviewing it was taking too long, so I've now pushed the branch "develop". It's unstable, but worked for me. Feel free to send PRs and the like :-)

@michield
Copy link
Member

michield commented Dec 3, 2017

Logged in as a shadow account on the last comment. @jryberg Have you managed to get the code? Any issues with it?

@JOduMonT
Copy link

@michield releasing the Dockerfile will
1' enthusiasm people and let them try to tweak it ;)
2' probably release pressure from your side

such I was expecting, a Dockerfile to probably fork it then make it available under alpine

@michield
Copy link
Member

michield commented Mar 13, 2018

The unstable code is here and it's been there since Dec 2017 :-)

I haven't had time to clean it up, but I've recently worked on it again, and will push some changes shortly.

@derBobby
Copy link

@michield Are you planning to make this production ready? I'm in search for a newsletter tool and would love to have a dockerized one for it.

@michield
Copy link
Member

Yes, my intention is to create a production version. However, lack of time, and a faulty laptop has delayed that a little.

@samtuke
Copy link
Contributor

samtuke commented Mar 29, 2018

@michield How about listing the outstanding tasks in a github issue so that @derBobby and others can help iron out the kinks? E.g. like phpList/core#238

@michield
Copy link
Member

Well, for now, it works nicely as a dev environment. Once we have more feedback on that, we can start looking into testing and production.

@michield
Copy link
Member

the develop branch has now been merged into master. If you use a versioned container, it will send the mails for real. Only the latest/dev one will not send out any emails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants