-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfiles #1
Comments
That's a good question for @michield |
Those are on the internal branch in the gitlab mirror of the repo. I may publish them here later, but I've added you to the project. https://gitlab.com/phpList/phplist-docker/tree/internal |
Thanks, I now have a phplist container based on your Dockerfile but using https://hub.docker.com/_/php/ as the base image (mainly just experimenting, but I might suggest some changes if I do anything useful). |
Yes, of course, that would be great. Maybe branch or fork away first and then PR the changes. |
Hi, I would like to have access to the Dockerfile as well and also permission to fork it. Depending how much work there is to get it up and running I might be able to contribute |
I'll try to spend some time to review them and make them ready for public viewing. As I recall, they're a bit messy at the moment :-) |
Reviewing it was taking too long, so I've now pushed the branch "develop". It's unstable, but worked for me. Feel free to send PRs and the like :-) |
Logged in as a shadow account on the last comment. @jryberg Have you managed to get the code? Any issues with it? |
@michield releasing the Dockerfile will such I was expecting, a Dockerfile to probably fork it then make it available under alpine |
The unstable code is here and it's been there since Dec 2017 :-) I haven't had time to clean it up, but I've recently worked on it again, and will push some changes shortly. |
@michield Are you planning to make this production ready? I'm in search for a newsletter tool and would love to have a dockerized one for it. |
Yes, my intention is to create a production version. However, lack of time, and a faulty laptop has delayed that a little. |
@michield How about listing the outstanding tasks in a github issue so that @derBobby and others can help iron out the kinks? E.g. like phpList/core#238 |
Well, for now, it works nicely as a dev environment. Once we have more feedback on that, we can start looking into testing and production. |
the develop branch has now been merged into master. If you use a versioned container, it will send the mails for real. Only the latest/dev one will not send out any emails. |
Can the Dockerfiles used to create the images hosted at https://hub.docker.com/u/phplist/ be included in this repository?
The text was updated successfully, but these errors were encountered: