Quick fix for the context download issue #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gaurav did you mean to assign this to me for review when you changed it to ready for review? |
|
@hlapp Sorry, I should have been clearer: nope, this PR doesn't need to be reviewed yet. I'm hoping that once we're properly set up on HiPerGator again I can install a more recent version of Java and then get the more comprehensive solution in PR #106 working. In that case, I'll close this issue. But if that doesn't work and I need to a temporary fix just to get Klados working again sooner, I'll use the code from this PR and submit it to you for review then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a quick fix for the context download issue, but storing the two most recent contexts in the JAR file so that they can used even without an internet connection. We will need the internet to download the Phyloref, CDAO and TCAN ontologies, but those can be stored in an
ontologies/directory, so in theory this gets us to the point where JPhyloRef can be run without an internet connection. However, this has not yet been tested on HiPerGaTor as we are in the process of moving from one server to another there.WIP: Hopefully this will not be needed at all if I can get the more comprehensive solution in PR #106 to work. But I wanted to hold onto this code if it is needed as an intermediate solution.