Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated files and dependencies #221

Open
dveeden opened this issue Oct 26, 2022 · 4 comments
Open

Outdated files and dependencies #221

dveeden opened this issue Oct 26, 2022 · 4 comments

Comments

@dveeden
Copy link

dveeden commented Oct 26, 2022

This repo seems to contain a lot of outdated and unmaintained things

  • monitor-snapshot/ seems to be years old copies of files
  • monitor/ seems very old (v4.0.0-beta.2 seems to be the most recent version)
  • cmd/main.go seems to be dependent on https://github.com/pingcap/tidb-ansible
  • cmd/montioring.go seems to be dependent on https://github.com/pingcap/tidb-ansible
  • platform-monitoring/ansible/ ansible specific
  • pkg/ansible/ ansible specific
  • README.md still mentioned the old ansible things. Mentions very old versions of TiDB.

A LICENSE file seems to be missing and none of the *.go files seem to have a copyright header.

@dveeden
Copy link
Author

dveeden commented Oct 26, 2022

@Ehco1996 @KanShiori @better0332 @amyangfei What do you think is the right way to get this fixed?

@dveeden
Copy link
Author

dveeden commented Oct 26, 2022

There are many pull requests from the SRE bot, which seem to indicate more that this isn't really maintained.

@dveeden
Copy link
Author

dveeden commented Oct 27, 2022

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Apr 26, 2024

There are many pull requests from the SRE bot, which seem to indicate more that this isn't really maintained.

I closed them. And now the <branch> dir in the release branches and master branch will be automatic updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants