Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Cleanup Bootstrap #11801

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Dec 5, 2024

No description provided.

@emeroad emeroad added the cleanup label Dec 5, 2024
@emeroad emeroad added this to the 3.1.0 milestone Dec 5, 2024
@emeroad emeroad force-pushed the #noissue_dd branch 2 times, most recently from 7ceccc7 to 7b638bd Compare December 5, 2024 08:22
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 43.85965% with 32 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (8132e25) to head (1951f60).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../navercorp/pinpoint/bootstrap/PinpointStarter.java 0.00% 8 Missing ⚠️
...pinpoint/bootstrap/config/PropertyLoaderUtils.java 0.00% 7 Missing ⚠️
...npoint/bootstrap/config/ProfilePropertyLoader.java 0.00% 3 Missing ⚠️
...orp/pinpoint/bootstrap/AgentIdResolverBuilder.java 0.00% 2 Missing ⚠️
...va/com/navercorp/pinpoint/bootstrap/AgentType.java 66.66% 1 Missing and 1 partial ⚠️
...inpoint/bootstrap/config/SimplePropertyLoader.java 0.00% 2 Missing ⚠️
...pinpoint/profiler/context/DefaultAsyncContext.java 0.00% 1 Missing and 1 partial ⚠️
...pinpoint/profiler/context/DisableAsyncContext.java 0.00% 1 Missing and 1 partial ⚠️
.../navercorp/pinpoint/bootstrap/AgentIdResolver.java 75.00% 0 Missing and 1 partial ⚠️
...va/com/navercorp/pinpoint/bootstrap/PathUtils.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11801      +/-   ##
============================================
+ Coverage     36.96%   36.98%   +0.02%     
- Complexity    12432    12441       +9     
============================================
  Files          4118     4121       +3     
  Lines        100740   100723      -17     
  Branches      10529    10530       +1     
============================================
+ Hits          37240    37254      +14     
+ Misses        60494    60458      -36     
- Partials       3006     3011       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit dd49d15 into pinpoint-apm:master Dec 5, 2024
3 checks passed
@emeroad emeroad deleted the #noissue_dd branch December 5, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant