From 38946c3639a3befc075ec40bf9438f6e8d47f3b2 Mon Sep 17 00:00:00 2001 From: ochorocho Date: Mon, 11 Sep 2023 16:08:16 +0200 Subject: [PATCH 1/3] Fix undefined array key for php8.1 --- Classes/Controller/FeedsController.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/Controller/FeedsController.php b/Classes/Controller/FeedsController.php index a2f9cca..b777473 100644 --- a/Classes/Controller/FeedsController.php +++ b/Classes/Controller/FeedsController.php @@ -54,8 +54,8 @@ public function injectFeedRepository(FeedRepository $feedRepository): void */ public function listAction() { - $limit = $this->settings['feedsLimit'] ? (int)($this->settings['feedsLimit']) : 10; - $configurations = GeneralUtility::intExplode(',', $this->settings['configuration'], true); + $limit = (int)($this->settings['feedsLimit'] ?? 10); + $configurations = GeneralUtility::intExplode(',', $this->settings['configuration'] ?? '', true); $feeds = $this->feedRepository->findByConfigurations($configurations, $limit); From 5e71a696b0835fdfd184c586b75640ac24aee7ad Mon Sep 17 00:00:00 2001 From: ochorocho Date: Mon, 11 Sep 2023 16:09:25 +0200 Subject: [PATCH 2/3] Add php 8.1 to test suite --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a035476..9223de1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,6 +12,7 @@ jobs: php-version: - 7.4 - 8.0 + - 8.1 steps: - name: Configure PHP ${{ matrix.php-version }} From 63cacb3c2c6ca6f507b650a8186bf0c07286d8bf Mon Sep 17 00:00:00 2001 From: ochorocho Date: Tue, 12 Sep 2023 12:22:06 +0000 Subject: [PATCH 3/3] Fix indentation --- Classes/Domain/Model/Configuration.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Classes/Domain/Model/Configuration.php b/Classes/Domain/Model/Configuration.php index 549e731..9815b0d 100644 --- a/Classes/Domain/Model/Configuration.php +++ b/Classes/Domain/Model/Configuration.php @@ -283,8 +283,8 @@ public function setPerformCleanUp(bool $performCleanUp): void /** * @return bool */ - public function getPerformCleanUp(): bool - { - return $this->performCleanUp; - } + public function getPerformCleanUp(): bool + { + return $this->performCleanUp; + } }