Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Acknowledgment timeout #124

Open
buholzer opened this issue Sep 7, 2013 · 2 comments
Open

Acknowledgment timeout #124

buholzer opened this issue Sep 7, 2013 · 2 comments
Milestone

Comments

@buholzer
Copy link

buholzer commented Sep 7, 2013

I understand that _acks is keeping track of acknowledgement's and that they are removed from _acks as soon as an acknowledgement successfully comes back from the server in the onData method.

  • What happens when acknowledgement's aren't sent back from the server, due to communication errors or busy server?
  • Will they stay forever in the _acks dictionary?
  • Should a timed method clean up old acknowledgements based on a timeout and inform the user about it?
  • Should we be able to set the timeout per connection or per message?

Suggestions welcome!

@pkyeck
Copy link
Owner

pkyeck commented Nov 18, 2013

this all sounds good to me - anyone with other feedback for this?

@patelparthc
Copy link

https://github.com/monder/socket.IO-objc has forked similar function but i want to know NSTimer is good option for this ? i want your suggestion Multiple Timer Function may effect performance, even if we invalidate is on ack timeout and ack received events ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants