Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline renderer robustness #7047

Open
MAG-AdrianMeredith opened this issue Oct 18, 2024 · 4 comments
Open

Outline renderer robustness #7047

MAG-AdrianMeredith opened this issue Oct 18, 2024 · 4 comments
Assignees

Comments

@MAG-AdrianMeredith
Copy link
Contributor

Description

When combining the new Outline Renderer with an LOD system there is a race condition that cause it to get out of sync leave a "zombie" mesh in the outline layer that cannot be removed. This occurs as a result of showing/hiding at the same time as modifying the outliner. When calling removeEntity() it attempts to only remove the currently visible meshinstances which in this case have changed since it was added.

outline-bug.mp4

Steps to Reproduce

  1. add an animated model to outline
  2. change mesh visibility
  3. remove the outline
@MAG-AdrianMeredith
Copy link
Contributor Author

MAG-AdrianMeredith commented Oct 18, 2024

Fix incoming, just a matter of ensuring all meshInstances are removed when calling removeEntity (not just the visible ones)

@mvaligursky
Copy link
Contributor

@MAG-AdrianMeredith - any update on the PR with the fix?

@MAG-AdrianMeredith
Copy link
Contributor Author

Somewhere, I did a fix on our fork just need to port it over will have a look tomorrow or if you're desperate for it you can find it here magnopus@f5ca71a

@mvaligursky
Copy link
Contributor

I'm happy to wait till tomorrow @MAG-AdrianMeredith :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants