Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster uploads by avoiding unneed large blob reads #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

djay
Copy link
Member

@djay djay commented Nov 26, 2024

replaces #155

fixed #167

As mentioned in the comments perhaps a better long term fix is to change zope.schema to avoid accessing properies if they are decorators and instead using something like - https://stackoverflow.com/questions/16169948/check-if-something-is-an-attribute-or-decorator-in-python first

@mister-roboto
Copy link

@djay thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@djay
Copy link
Member Author

djay commented Nov 26, 2024

I created a ticket for zope.schema suggestion. zopefoundation/zope.schema#127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imports/uploads slow due to reading files into memory due to schema validation
2 participants