Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support modern editable installs #2749

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

graingert-coef
Copy link
Contributor

@graingert-coef graingert-coef commented Feb 7, 2024

pip is switching to pyproject based editable installs pypa/pip#11457 which breaks the celery tests see #2735 (comment)

builds on top of #2735

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • move dash source code to src/dash
    • configure the project with new src layout
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

I don't think this needs a changelog entry

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • this GitHub #PR number updates the dash docs
    • here is the show and tell thread in Plotly Dash community

@graingert-coef graingert-coef force-pushed the support-modern-editable-installs branch 2 times, most recently from 713b4d5 to bdae1a7 Compare February 7, 2024 10:39
@graingert-coef graingert-coef marked this pull request as ready for review February 7, 2024 12:39
@graingert-coef graingert-coef force-pushed the support-modern-editable-installs branch 5 times, most recently from a3ea010 to aefad57 Compare February 14, 2024 11:11
@gvwilson gvwilson self-assigned this May 27, 2024
@gvwilson gvwilson assigned T4rk1n and unassigned gvwilson Jun 6, 2024
@gvwilson gvwilson added feature something new P2 considered for next cycle labels Aug 13, 2024
@gvwilson
Copy link
Contributor

@graingert-coef thank you again for this PR - we're rethinking our build environments right now, so we will revisit it in the next cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants