Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book recipes do not render graphs #248

Open
Nick-Pearson opened this issue Nov 17, 2024 · 1 comment
Open

Book recipes do not render graphs #248

Nick-Pearson opened this issue Nov 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Nick-Pearson
Copy link
Contributor

The graphs in the book recipes are not rendering due to the inline html being generated with an old version of plotly.js
They fail with this error

Uncaught TypeError: Cannot read properties of undefined (reading 'select')
    at scatter_plots.html:347:31

e.g. Scatter Plots

Additionally the code in the book recipes can drift from the code in the examples directory.

MD Book has a feature which allows inserting code directly from other files https://rust-lang.github.io/mdBook/format/mdbook.html#including-portions-of-a-file
The book could include rust source code and rendered html fragments directly from the examples. That way it can be ensured the recipes compile and can produce a rendered graph

I am happy to submit a PR for this

@andrei-ng
Copy link
Collaborator

That would be awesome if you are willing to do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants