From a7f51283a2159c7cb8d692eac59360f84d3bf8e7 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Thu, 19 Dec 2024 22:00:49 +0900 Subject: [PATCH] chore(.github/workflows): improve workflow with removing duplicated configs (#2918) --- .github/workflows/compressed-size-action.yml | 1 - .github/workflows/cr.yml | 2 +- .github/workflows/lint-and-type.yml | 3 +-- .github/workflows/publish.yml | 3 +-- .github/workflows/test-multiple-builds.yml | 3 +-- .github/workflows/test-multiple-versions.yml | 3 +-- .github/workflows/test-old-typescript.yml | 3 +-- 7 files changed, 6 insertions(+), 12 deletions(-) diff --git a/.github/workflows/compressed-size-action.yml b/.github/workflows/compressed-size-action.yml index dfce78f10b..278d0b2a01 100644 --- a/.github/workflows/compressed-size-action.yml +++ b/.github/workflows/compressed-size-action.yml @@ -12,7 +12,6 @@ jobs: with: node-version: 20 cache: 'pnpm' - cache-dependency-path: '**/pnpm-lock.yaml' - uses: preactjs/compressed-size-action@v2 with: pattern: './dist/**/*.{js,mjs}' diff --git a/.github/workflows/cr.yml b/.github/workflows/cr.yml index 4117bdd302..0ea400905e 100644 --- a/.github/workflows/cr.yml +++ b/.github/workflows/cr.yml @@ -7,7 +7,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - run: corepack enable + - uses: pnpm/action-setup@v4 - uses: actions/setup-node@v4 with: node-version: 20 diff --git a/.github/workflows/lint-and-type.yml b/.github/workflows/lint-and-type.yml index db51b1d985..f13ceb8058 100644 --- a/.github/workflows/lint-and-type.yml +++ b/.github/workflows/lint-and-type.yml @@ -16,8 +16,7 @@ jobs: with: node-version: 20 cache: 'pnpm' - cache-dependency-path: '**/pnpm-lock.yaml' - - run: pnpm install --frozen-lockfile + - run: pnpm install - run: pnpm test:format - run: pnpm test:types - run: pnpm test:lint diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 82e2cedd4d..8613b881d3 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -15,8 +15,7 @@ jobs: node-version: 20 registry-url: 'https://registry.npmjs.org' cache: 'pnpm' - cache-dependency-path: '**/pnpm-lock.yaml' - - run: pnpm install --frozen-lockfile + - run: pnpm install - run: pnpm test - run: pnpm build - run: npm publish diff --git a/.github/workflows/test-multiple-builds.yml b/.github/workflows/test-multiple-builds.yml index 7120cf62a4..2680c54355 100644 --- a/.github/workflows/test-multiple-builds.yml +++ b/.github/workflows/test-multiple-builds.yml @@ -21,8 +21,7 @@ jobs: with: node-version: 20 cache: 'pnpm' - cache-dependency-path: '**/pnpm-lock.yaml' - - run: pnpm install --frozen-lockfile + - run: pnpm install - run: pnpm build - name: Patch for DEV-ONLY if: ${{ matrix.env == 'development' }} diff --git a/.github/workflows/test-multiple-versions.yml b/.github/workflows/test-multiple-versions.yml index 7ea4fba10a..5aea49a78f 100644 --- a/.github/workflows/test-multiple-versions.yml +++ b/.github/workflows/test-multiple-versions.yml @@ -16,8 +16,7 @@ jobs: with: node-version: 20 cache: 'pnpm' - cache-dependency-path: '**/pnpm-lock.yaml' - - run: pnpm install --frozen-lockfile + - run: pnpm install - run: pnpm build # we don't have any other workflows to test build - run: pnpm test:spec diff --git a/.github/workflows/test-old-typescript.yml b/.github/workflows/test-old-typescript.yml index 5c12cf6d18..3ebc39a5a5 100644 --- a/.github/workflows/test-old-typescript.yml +++ b/.github/workflows/test-old-typescript.yml @@ -31,8 +31,7 @@ jobs: with: node-version: 20 cache: 'pnpm' - cache-dependency-path: '**/pnpm-lock.yaml' - - run: pnpm install --frozen-lockfile + - run: pnpm install - run: pnpm build - name: Patch for all TS run: |