Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable names related to fleeing battles being logically inverted #1219

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

icebound777
Copy link
Contributor

Variable and enum names related to allowing to run from battle are logically inverted. This PR fixes that.

Stumbled upon this while tinkering with custom conditions for running from battle. Found the related code in btl_states_actions.c odd, then later on noticed the code in btl_states_menues.c being logically wrong.

Variable and enum names related to allowing to run from battle are
logically inverted. This fixes that
Copy link
Member

@ethteck ethteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Once BS_FLAGS2_CAN_FLEE is renamed in the header and CI passes, I'm good to merge this

@z64a
Copy link
Collaborator

z64a commented Nov 7, 2024

Please use EncounterStatus::forbidFleeing, as that is what dx has.

@pmret pmret deleted a comment from BowserSlug Nov 9, 2024
@ethteck ethteck merged commit 81875cf into pmret:main Nov 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants