Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Sponsorblock does not work in background play #257

Open
7 tasks done
Fehertukor opened this issue Oct 11, 2022 · 17 comments
Open
7 tasks done

Sponsorblock does not work in background play #257

Fehertukor opened this issue Oct 11, 2022 · 17 comments
Labels
bug Something isn't working

Comments

@Fehertukor
Copy link

Checklist

  • I am able to reproduce the bug with the latest version.
  • I am not able to reproduce the bug with the same version of upstream NewPipe.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.24.0

Steps to reproduce the bug

Hello,

I play some videos in the background during work and with the least update the Sponsors are back!...:)
Please check this for me.
What I do:

  1. Long press video in list -> start playing in the background (same happens when push (background) button in video "description")
  2. Does not skip sponsor, like in video mode.

Example:
https://www.youtube.com/watch?v=3qb1pMeAqVg

Expected behavior

To skip sponsors as it did.

Actual behavior

Does not skip

Screenshots/Screen recordings

No response

Logs

No crach

Affected Android/Custom ROM version

Android 11

Affected device model

No response

Additional information

No response

@Fehertukor Fehertukor added the bug Something isn't working label Oct 11, 2022
@CounterContradiction
Copy link

CounterContradiction commented Oct 19, 2022

Can confirm this bug exists following the steps. Another way to see this bug is to use the background button on a playlist. Sponsorblock does work if using the background button under the video.
Screenshot_20221019-192636

Screenshot_20221019-192718

Screenshot_20221019-192652

@Fehertukor
Copy link
Author

Thanks! I didn't know!

@CounterContradiction
Copy link

Why did you close it? It's a real bug. I just added more info so that hopefully it'll be fixed next version. AFAIK, Sponsorblock does work on all three cases prior to this version (24.0)

@Fehertukor
Copy link
Author

Miss click

@Fehertukor Fehertukor reopened this Oct 19, 2022
@Fehertukor
Copy link
Author

I will try, thanks!

@pickly-spec
Copy link

This particular issue is still not resolved after the latest update, and is not affected by switching the api url to a mirror

@g1t3m
Copy link

g1t3m commented Dec 27, 2022

I can attest to this issue still being unresolved following the latest update as portions of videos highlighted by Sponsorblock still do not skip when "Start playing in the background" or "Enqueue (next)" is selected from the secondary menu. I even tested to see if the third case @CounterContradiction mentioned was affected and it seems that no longer works as well.

@g1t3m
Copy link

g1t3m commented Dec 27, 2022

Screenshot_20221227-085035

Background icon is pressed for single video

Screenshot_20221227-085429

Background icon pressed on channel page

Screenshot_20221227-085735

Enqueue button is pressed on secondary menu

@CounterContradiction
Copy link

@g1t3m I forgot to mention it in my comment, but for sponsorblock to work, you have to let the video play first before pressing the background button.

@Fehertukor
Copy link
Author

I can testify that for a temporary solution (for sponsorblock in background play),
starting the video in "normal" play than switching to background play works(but not consistently).

@qwrwed
Copy link

qwrwed commented Mar 28, 2023

I have also run into this issue on Android 11. Sponsors (non-music segments, in my case) are not skipped in the background unless the video is first played in the foreground.

@shadyx49
Copy link

bump

@Fehertukor
Copy link
Author

@polymorphicshade
Would this solution possible?
(I know maybe it is weird solution).
When we click on background play it starts the video in 144p for 1-2 seconds(in the background)/grabs the sponsor skip data/ and than switch automatically to the real background play.
Possibly leave it as an option in the settings for those who want it to work for now.

Thank you for your work and everybody who works on this project!

@Mobious
Copy link

Mobious commented Jul 3, 2023

This is apparently still an issue in version 0.25.1

@TalkSickWaist
Copy link

Still an issue. Any chance someone wants to spend a few minutes hacking away at this over the weekend? 🙃

@hetszunyukapanyanyimonyok

Any news about this? Because I have the same issue.

@ihatemakinganaccount
Copy link

Still no solution I see, but at least a workaround: start playing a video normally or in popup, and then switch it to background. SB will work for all the videos in the playlist, even if you keep adding new videos. It'll only stop of you start a new background playback from scratch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

11 participants