Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

f-droid #8

Open
bingoxo opened this issue Nov 30, 2020 · 17 comments
Open

f-droid #8

bingoxo opened this issue Nov 30, 2020 · 17 comments
Labels
enhancement New feature or request

Comments

@bingoxo
Copy link

bingoxo commented Nov 30, 2020

can you please add your fork to f-droid so it can have a larger audience and at same time we can have automatic updates

@bingoxo bingoxo added the enhancement New feature or request label Nov 30, 2020
@emacsomancer
Copy link

preferably also via a separate repo like the main newpipe does; fdroid sometimes takes a while to roll out updates

@ajayyy
Copy link

ajayyy commented Dec 12, 2020

Depends on #12

@seniorm0ment
Copy link

+1, main repo and a hosted one or maybe izzy's repo.

@je-vv
Copy link

je-vv commented Feb 17, 2021

I'd also say both, the official one, and a custom onel with faster updates, like the newpipe one, but keeping the same f-droid FLOSS policies on the custom one... Thanks !

@Shallrath
Copy link

Shallrath commented Jul 2, 2021

This is the main reason that's keeping me from using this: Newpipe needs frequent updates so it won't stop working with YouTube. Keeping an app updated manually on multiple devices is much more effort than just skipping sponsored segments manually...

@bingoxo
Copy link
Author

bingoxo commented Jul 2, 2021

This is the main reason that's keeping me from using this: Newpipe needs frequent updates so it won't stop working with YouTube. Keeping an app updated manually on multiple devices is much more effort than just skipping sponsored segments manually...

the updates are not that frequent plus fdroid updates the same way newpipe updates unless you are rooted (which is bad for security anyway)

@seniorm0ment
Copy link

fdroid does some verifications, not all repos but their main and izzy's repo i know do

@bingoxo
Copy link
Author

bingoxo commented Jul 2, 2021

fdroid does some verifications, not all repos but their main and izzy's repo i know do

the advantage of using fdroid's main repo is that you trust them to build from source instead of downloading whatever binary the main dev puts in releases , but again , unless you audit the code yourself you still need to trust the dev anyway

izzy afaik just grabs binaries from releases

@seniorm0ment
Copy link

https://apt.izzysoft.de/fdroid/index/info
I meant more the malware and library scans, but yeah of course I'd prefer the main repo if possible.

but again , unless you audit the code yourself you still need to trust the dev anyway

as with anything

frequent updates

It doesn't need frequent updates but there are times where Google does something and Newpipe fixes it then a day later it's broken again then a few more times then Newpipe is fine for months if not longer.
It's just when it breaks, you need that update pretty quickly otherwise the the app is useless. f google.

@mooreye
Copy link

mooreye commented Mar 28, 2022

I would prefer a repo with only NewPipe x SponsorBlock, as Izzy contains proprietary software.
On a side note, is this app capable of self-updating? The "show notification if update available" option is still there, but when I tap "Check for updates", there is no feedback at all. If the app could just grab newest release from GitHub automatically, it would be good enough for me (Signal does something similar).

EDIT:
Well it's not, I had to download APK manually...

gilbsgilbs added a commit to gilbsgilbs/NewPipeSponsorBlock that referenced this issue May 1, 2022
Upstream code checks whether the current APK was signed with the release
key for various reasons:
- in order to show/hide the "Updates" settings menu
- in order to make the "Updates" settings menu searchable or not
- in order to check/not check for updates at the application start

This behavior was removed in NewPipe SponsorBlock fork, but it probably
shouldn't have been:

- the newer APK installation won't work if the locally installed APK
  wasn't signed with the same key
- `isReleaseApk` function was still invoked in NewPipe SponsorBlock to
  allow searching "Updates" settings from settings menu. But as the
  fingerprint wasn't correct (see 25575ea), the update settings
  would not be searchable which is a bug
- this is a requirement for F-Droid inclusion as they sign their APKs
  with their own keys (so the updater wouldn't work) and they explicitly
  forbid auto-updaters by policy (see also
  polymorphicshade#8)
@CodeCubeNeo
Copy link

Any updates on this?

@gilbsgilbs
Copy link

Just submitted https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11402 . We'll see where this goes. 🤞

@Atemu
Copy link

Atemu commented Jul 20, 2022

We'd probably want to wait for the Tubular rebranding. That might entail a new app ID.

@gilbsgilbs
Copy link

gilbsgilbs commented Jul 20, 2022

I'll leave it in draft then. Please let me know when the rebranding happens. It may also be needed to update the fastlane metadata btw.

I'd argue against an app id change though because it's rather internal and will mostly cause upgrade issues to users, who will likely have to reimport their subscriptions and recreate their preferences.

@killerrook killerrook mentioned this issue Nov 29, 2022
6 tasks
@trymeouteh
Copy link

preferably also via a separate repo like the main newpipe does; fdroid sometimes takes a while to roll out updates

Agreed

@licaon-kter
Copy link

no news?

@Mynacol
Copy link

Mynacol commented Dec 6, 2023

I'm working on a new build recipe, but currently the build fails due to missing dependencies on jitpack.io.
The newest NewPipe commits don't have this problem, so I'd wait for version 0.26.

But until then we should figure out if any rebranding is wanted/needed for F-Droid inclusion.

Compilation error
$ ./gradlew build
> Task :app:mergeReleaseNativeLibs FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeReleaseNativeLibs'.
> Could not resolve all files for configuration ':app:releaseRuntimeClasspath'.
   > Could not find com.github.TeamNewPipe.NewPipeExtractor:extractor:v0.22.7.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom
       - https://repo.maven.apache.org/maven2/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom
       - https://jitpack.io/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom
       - https://repo.clojars.org/com/github/TeamNewPipe/NewPipeExtractor/extractor/v0.22.7/extractor-v0.22.7.pom
     Required by:
         project :app > com.github.TeamNewPipe:NewPipeExtractor:v0.22.7
   > Could not find com.github.TeamNewPipe.NewPipeExtractor:NewPipeExtractor:v0.22.7.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom
       - https://repo.maven.apache.org/maven2/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom
       - https://jitpack.io/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom
       - https://repo.clojars.org/com/github/TeamNewPipe/NewPipeExtractor/NewPipeExtractor/v0.22.7/NewPipeExtractor-v0.22.7.pom
     Required by:
         project :app > com.github.TeamNewPipe:NewPipeExtractor:v0.22.7
   > Could not find com.github.TeamNewPipe.NewPipeExtractor:timeago-parser:v0.22.7.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom
       - https://repo.maven.apache.org/maven2/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom
       - https://jitpack.io/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom
       - https://repo.clojars.org/com/github/TeamNewPipe/NewPipeExtractor/timeago-parser/v0.22.7/timeago-parser-v0.22.7.pom
     Required by:
         project :app > com.github.TeamNewPipe:NewPipeExtractor:v0.22.7

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 19s
5 actionable tasks: 4 executed, 1 up-to-date

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests