Add EmptyDrops to the pipeline #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Peter,
The code for EmptyDrops and related metrics is in
bin. The goal of this script is to get knee, inflection point, end of cliff points (and their ranks), as well as significance testing for non-empty droplets. I'm thinking we probably need to offer an option to choose FDR threshold. Expected outputs of this script are two files, one with all of the critical points and their ranks, and one with barcodes along with their FDR. This script should go afterCellBenderbecause I use CellBender outputs to guess plateau points. Please let me know if I can clarify anything!Ha