Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords should not be logged #73

Open
fweep opened this issue Nov 18, 2023 · 2 comments
Open

Passwords should not be logged #73

fweep opened this issue Nov 18, 2023 · 2 comments

Comments

@fweep
Copy link

fweep commented Nov 18, 2023

On container startup, passwords are logged in plaintext. I've replaced them with REDACTED below, but they're plaintext. If you feel this is useful diagnostic information, please hide it behind a debug flag.

postfixadmin  | Postfixadmin not found in /var/www/html - copying now...
postfixadmin  | Complete! Postfixadmin has been successfully copied to /var/www/html
postfixadmin  | Write config to /var/www/html/config.local.php
postfixadmin  | <?php
postfixadmin  |                 $CONF['database_type'] = 'pgsql';
postfixadmin  |                 $CONF['database_host'] = 'REDACTED';
postfixadmin  |                 $CONF['database_port'] = '5432';
postfixadmin  |                 $CONF['database_user'] = 'postfixadmin';
postfixadmin  |                 $CONF['database_password'] = 'REDACTED';
postfixadmin  |                 $CONF['database_name'] = 'postfixadmin';
postfixadmin  |                 $CONF['setup_password'] = 'REDACTED';
postfixadmin  |                 $CONF['smtp_server'] = 'REDACTED';
postfixadmin  |                 $CONF['smtp_port'] = '25';
postfixadmin  |                 $CONF['encrypt'] = 'php_crypt:SHA512';
postfixadmin  |                 $CONF['configured'] = true;
postfixadmin  |                 ?>
@dpurnam
Copy link

dpurnam commented Nov 9, 2024

A Related issue I experienced is that the Stack Trace error/warning displayed confidential credentials.
Definitely a +1 for debug/tracing enable/disable configuration variable/switch

@DavidGoodwin
Copy link
Member

perhaps we need to litter the code with #SensitiveParameter - at least for newer versions of PHP that would stop them being displayed in some backtraces etc

see also https://wiki.php.net/rfc/redact_parameters_in_back_traces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants