Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard banner glow looks a bit silly with lighter banners #11594

Open
SupDos opened this issue Oct 28, 2024 · 2 comments
Open

Dashboard banner glow looks a bit silly with lighter banners #11594

SupDos opened this issue Oct 28, 2024 · 2 comments
Labels
area:dashboard type:cosmetic

Comments

@SupDos
Copy link

SupDos commented Oct 28, 2024

Previously there's only been darker banners, so the glow wasn't super noticeable/in the way, but now that there's a light banner the glow kinda looks like a bug compared to the rest of the page design. Maybe it should just be contained to the banner area? Like so:

overflow no overflow
image image
image image
firefox_2024-10-28_13-13-57.mp4
@Tanza3D
Copy link
Contributor

Tanza3D commented Oct 28, 2024

personally agree with this, definitely best to contain it to the banner container itself

@peppy
Copy link
Member

peppy commented Nov 13, 2024

I think it looks cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dashboard type:cosmetic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@peppy @SupDos @Tanza3D @Joehuu