Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when TLS CA file is missing #338

Open
claudiofahey opened this issue Nov 15, 2021 · 0 comments
Open

Panic when TLS CA file is missing #338

claudiofahey opened this issue Nov 15, 2021 · 0 comments

Comments

@claudiofahey
Copy link

Problem description

When using the client with TLS enabled, a missing TLS CA file results in the following panic.

thread '<unnamed>' panicked at 'should be valid path: Os { code: 2, kind: NotFound, message: "No such file or directory" }', pravega-client-rust-fa7c139c5174e088/0833868/config/src/lib.rs:128:49

There are two problems. First, the message is unclear what the problem is. Which file is missing? Is it a keycloak file, TLS file, or something else? Did I set the wrong env var?

Problem location

pravega-client-rust-fa7c139c5174e088/0833868/config/src/lib.rs:128

Suggestions for an improvement

  1. The error message should identify the name of the file that is missing.
  2. Since Pravega client is a library, this should should be returned as an error, not result in a panic. The application can panic if appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant