Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for auth/tls enabled settings unclear #405

Open
crazyzhou opened this issue Nov 16, 2022 · 1 comment
Open

Documentation for auth/tls enabled settings unclear #405

crazyzhou opened this issue Nov 16, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@crazyzhou
Copy link
Contributor

Problem description
The stream manager in python client has two flags to turn on the auth and tls, but it is not mentioned in the documentation or code comments, especially this line is misleading which makes a bad example for users.

/// manager=pravega_client.StreamManager("tls://127.0.0.1:9090")

Problem location
stream_manager.rs

Suggestions for an improvement
Add some more documentation to explain these two flags, and in the documentation PythonBindings.md and tests pravega_reader_test.py, it would be better to use explicit flag settings.

@crazyzhou crazyzhou added the documentation Improvements or additions to documentation label Nov 16, 2022
@pushker001
Copy link

hey, I want to solve this issue can you help me with how I can do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants