Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase #100 #239

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Rebase #100 #239

wants to merge 16 commits into from

Conversation

laggingreflex
Copy link

Rebase #100 against current master

@developit
Copy link
Member

Oh wow this is a lot of work, thanks a million. I noticed you published preact-router-nested to npm - are you successfully using this PR? That helps make sure it's good to go 👍

@laggingreflex
Copy link
Author

Glad to help. I did use it but only very briefly, so can't vouch for it all that much, but it did seem to work as intended.

The reason I didn't use it very much was that I was finding it cumbersome in my personal use case, nesting all the routes in the layout I wanted. Then there's basePath and path props issues that you need to deal with, especially if you're also implementing a navigation to go along with all the nested routes. I created something different that suits my needs better: https://github.com/laggingreflex/dynamic-router, at least for now.

@rjmackay
Copy link

@developit whats needed to get this or #100 merged?

@developit
Copy link
Member

Just some thorough battle testing (or more unit tests?)

@developit developit self-assigned this Feb 11, 2018
@developit developit self-requested a review February 11, 2018 23:37
@ghost ghost mentioned this pull request Nov 9, 2018
@ghost
Copy link

ghost commented Nov 9, 2018

Hi quickly updated - #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants