-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase #100 #239
base: main
Are you sure you want to change the base?
Rebase #100 #239
Conversation
Oh wow this is a lot of work, thanks a million. I noticed you published preact-router-nested to npm - are you successfully using this PR? That helps make sure it's good to go 👍 |
Glad to help. I did use it but only very briefly, so can't vouch for it all that much, but it did seem to work as intended. The reason I didn't use it very much was that I was finding it cumbersome in my personal use case, nesting all the routes in the layout I wanted. Then there's |
@developit whats needed to get this or #100 merged? |
Just some thorough battle testing (or more unit tests?) |
Hi quickly updated - #293 |
Rebase #100 against current master