-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Documentation #467
Conversation
My preference would be to recommend adding the plugin config to the |
This was more for just the README.md for people's reference, but if it's applicable then might as well - do you mind referencing where? (can't seem to find anywhere I can add it to, and I'm at work) |
Same place that documents the CLI option: https://prettier.io/docs/en/plugins#using-plugins {
"plugins": ["@prettier/plugin-pug"]
} |
You did make me remember another file for editing, so caught that whilst it was in my head. Thanks for unintentionally reminding me. Some people can just add it to the file, but for a CLI lover (like myself) I'd rather stick to having it in-line. You're right though, the other methods should also be covered. This PR was originally gonna cover just the method that's documented, but I'll have a look later and add that in if time's on my side. (if @Shinigami92 or anyone else doesn't do it before me) |
So is this ready to merge? Or do you need to do something else and right now you cant because e.g. you are out of home, touching grass? |
You won't believe this fella. Grass is real. I thought it was a myth. Yep, still a draft - lost the button to change the PR state back to draft. If you give me a few hours, I'll make the necessary commits to address the various other methods. |
docs/guide/index.md
Outdated
@@ -85,22 +122,4 @@ Pug code with automatic formatting: | |||
|
|||
## Type support in configuration file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this content section do not have content anymore?
You can also please run prettier before doing a commit, that does some stuff for you |
052cf09
to
976ef1a
Compare
Apologies, didn't cross my mind - my environment's changed so I'm still reinstalling packages 😓
Re: header, amended that on the latest commit, looks like I won't be doing anything that requires thought after work in the future as I'm clearly pooped hahaha |
Just to avoid #463 occurring again, here's a change to README.md to reflect the latest version's usage changes.