Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionMenu with overflow doesn’t contain scrollbars within its rounded border #4938

Open
dylanatsmith opened this issue Sep 9, 2024 · 6 comments

Comments

@dylanatsmith
Copy link
Contributor

Description

Scrollbar contained within rounded corners of ActionList

image

Steps to reproduce

  1. Put a whole bunch of items in an ActionMenu too short to contain them
  2. You may need to force enable scrollbars at OS level

Version

Whatever’s in dotcom

Browser

No response

@dylanatsmith dylanatsmith added the bug Something isn't working label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Uh oh! @dylanatsmith, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@siddharthkp
Copy link
Member

siddharthkp commented Sep 10, 2024

Just passing by: overflow: scroll should be on the ActionList inside the Overlay. not on the overflow itself, that way we can ensure the border radius of the Overlay stays intact

@lesliecdubs
Copy link
Member

Wondering if someone in Primer Design might be able to take a look and weigh in on the CSS change needed here?

@lesliecdubs lesliecdubs removed the react label Sep 16, 2024
@tallys
Copy link

tallys commented Oct 21, 2024

@camertron can you follow up on this if it's React?

@lesliecdubs
Copy link
Member

lesliecdubs commented Nov 6, 2024

@tallys confirmed via Storybook that I believe this is happening in React.

@francinelucca
Copy link
Member

Tested this suggestion: #4938 (comment). Setting the overflow inside the ActionList doesn't solve the problem by itself because the ActionList is unaware of the max-height set by the overlay due to the overlay being absolutely positioned. In order for the overflow to work in the ActionList, it would have to be given a max-height as well. Throwing this back in the backlog as a solution for this will require further discussion

@francinelucca francinelucca removed their assignment Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants