-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates! #266
base: master
Are you sure you want to change the base?
Templates! #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far. It looks like there's still some work to do here, but let me know if there's anything specifically that you want feedback on.
These edits have been made to the home page after the 'featured apps' section and before the 'Build' section.
I would be in favor of merging the quick starts into the 'Build' section, since that's what it's for. We could make that section more concise if it feels like too much.
|
||
.code { | ||
padding: 10px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to do these with Primer:
p1
will give you a little padding, p6
will give you a lot of padding.
Let's keep the code snippet styling consistent with our existing patterns:
And attaching this Glitch resource if it helps! |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
Still looks relevant. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
I agree that we should finish this PR, help welcome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot. I don't know how this works though... But the concept seems nice
Is anyone working on this anymore? This seems like a good feature. |
Nobody is working on it, would you like to help finish it up? |
I can if I can figure out how this works (I'm not used to stuff like this, but I try) |
Ok, I think I can work on this, but I need to know what is stopping this from being merged (other than feedback-alex) |
don't worry about alex-feedback. Can you build the page locally and see if it all looks good to you? There is a comment by Brandon that I don't think was addressed yet: #266 (comment) I think he says we should use a class from primer.css instead of setting padding in px explicitly |
I don't know how to build a page locally, and I don't know anything about classes from primer.css, as I thought you could only have classes in html then do stuff to them in css. CONCLUSION: I have no idea how to help on any of that |
This PR is for adding the design additions to feature the 'use case'/'template'/'blueprints'/'quickstarts' we've added to the
create-probot-app
script in probot/create-probot-app#36 which is live in v3 of the script!Here's where things are at right now:
Regular zoom:
Zoomed out for context:
I made 3 just to see how they filled the space.
These edits have been made to the home page after the 'featured apps' section and before the 'Build' section. I've also begun working on giving there 'Quick starts' a more permanent home in the docs: in
docs/quickstarts
. Eventually those code changes will need to happen here in probot/probot, but since the work is mostly html/css, I've been working on it in conjunction with this PR and sharing screenshots + (VERY) WIP code here:Regular zoom:
Zoomed out for context:
Code for there docs pages in gist. (You'll probably have to click raw to see the html in not weird un-styled markdown rendering)
To Do:
/docs/quickstarts.md
code snippet section to better match https://user-images.githubusercontent.com/6744014/47388341-c2827b80-d6c6-11e8-8831-be274510b59c.png