Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jingle: XEP-0166, XEP-0234, XEP-0261, XEP-0047 #1890

Conversation

H3rnand3zzz
Copy link
Contributor

@H3rnand3zzz H3rnand3zzz commented Sep 18, 2023

Yet to be finished, the plan* is to

  • Pass autotests on the Github.
  • Complete all TODOs
  • Improve stability (e.g. file permissions etc. validation, handle errors on write)
  • Add autocomplete
  • Improve security (file name, size validation etc.)
  • Detect and fix mem leaks with the Valgrind
  • Add at least some autotests
  • Code Review by the Profanity team
  • Release

*The plan is not final, it might change.

How to test the functionality

/help jingle

I ran valgrind when using my new feature

planned

Fix #1871
(rather implement, but github understands only fix to link the PR as a potential solution for the issue).

Jingle is a session negotiation protocol,
it can not transfer data by itself,
but it enables us to transfer data
over negotiated channels.

To transfer files over Jingle, the IBB is a required channel,
it's very stable (over XMPP), but it's slow.

It's planned to add Socks5 and over protocols in the future
updates,
but for now this is a minimal setup to use the Jingle for file transfer.

Special thanks to the @jubalh and @jaeckel for their support and
contributions.
@H3rnand3zzz H3rnand3zzz force-pushed the feature/jingle-file-transfer branch from cfe1eb5 to f36e4bb Compare September 18, 2023 21:01
@H3rnand3zzz
Copy link
Contributor Author

It's almost ready, but I don't have a time currently. Whoever wants to, can continue this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Direct File Transfer (Jingle: XEP-0166, XEP-0234, XEP-0261)
2 participants