Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show encryption for historical messages #1910

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Show encryption for historical messages #1910

merged 1 commit into from
Nov 6, 2023

Conversation

H3rnand3zzz
Copy link
Contributor

See commit message.

  • No need to run valgrind when using my new feature

How to test the functionality

  • Use page up in the chat window until you see historical message. Encryption used should be displayed accordingly.

@H3rnand3zzz
Show encryption for historical messages
7af0e9b 
Refactor getting char, introduce get_show_char() to follow DRY principle.

In theory, performance might be negatively affected after this change.

Ideally get_show_char should be optimized in the future.
jubalh
jubalh approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@jubalh jubalh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been cool to have this in 2 commits. One that adds the new function in the existing places to DRY. And then another one that makes encryption char work for history (and also uses that new function).
But its okay.

@jubalh jubalh added this to the next milestone Nov 3, 2023
@jubalh jubalh merged commit 83fdd9b into profanity-im:master Nov 6, 2023
6 checks passed
@H3rnand3zzz H3rnand3zzz deleted the fix/show-char-dry-and-db branch November 7, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubalh jubalh jubalh approved these changes

Assignees

@H3rnand3zzz H3rnand3zzz

Labels
improvement UI
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.
2 participants
@H3rnand3zzz @jubalh