concat::fragment does not seem to notify properly

[faxm0dem]

Describe the Bug

When using a notify meta parameter in a concat::fragment, the target resource doesn't get notified.

Expected Behavior

When a concat::fragment's state changes, it should properly notify the target resource.

Steps to Reproduce

Example code:

service { 'foo':
  ensure => 'running',
}

concat { '/tmp/foo':
  ensure => 'present',
}

concat::fragment { '/tmp/foo bar':
  target  => '/tmp/foo',
  content => 'bar',
  order   => '10',
  notify  => Service['foo'],
}

1. Make sure service foo is running
2. Make sure file /tmp/foo is not present
3. Run puppet apply on the above code

Notice: Compiled catalog for localhost in environment production in 0.08 seconds
Notice: /Stage[main]/Main/Concat[/tmp/foo]/File[/tmp/foo]/ensure: defined content as '{sha256}fcde2b2edba56bf408601fb721fe9b5c338d10ee429ea04fae5511b68fbf8fb9'
Notice: Applied catalog in 0.03 seconds

As you can see, even though the file changed, it didn't trigger restart of the service.

Environment

• Version 6.2.0
• Platform Debian 11.4

[b4ldr]

looks like this could be the same issue as MODULES-7533 (also see #430)

[ekohl]

For some reason these meta parameters are explicitly not copied here:

puppetlabs-concat/lib/puppet/type/concat_file.rb

Line 344 in 4148c4b

excluded_metaparams = [:before, :notify, :require, :subscribe, :tag]

It was introduced in dd88b1a but it doesn't explain why those were excluded.

[vchepkov]

IMHO, one should use concat's resource notify, not an single fragment - result is the same, isn't it?

[faxm0dem]

I can imagine cases where one fragment should notify the service, but not another.
For instance, a changed comment in a config file shouldn't restart the service.

[b4ldr]

IMHO, one should use concat's resource notify, not an single fragment - result is the same, isn't it?

A real world example we have for this is the puppet.conf file on the puppetserver. most changes to this file are only read by the agent and dont require any notify. however changes to the server section require the puppetserver to be reloaded