Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9.0.1 breaks compatibility with pre-Puppet 7.17 #803

Closed
nmburgan opened this issue Jan 12, 2024 · 2 comments · Fixed by #804
Closed

v9.0.1 breaks compatibility with pre-Puppet 7.17 #803

nmburgan opened this issue Jan 12, 2024 · 2 comments · Fixed by #804

Comments

@nmburgan
Copy link

nmburgan commented Jan 12, 2024

Describe the Bug

This breaks compatibility with pre-7.17 agents, as this was not implemented until then. For example, when the postgresql module uses it with a Puppet 6 agent:

Error: /Stage[main]/Postgresql::Server::Config/Postgresql::Server::Instance::Config[main]/Concat[/var/lib/pgsql/14/data/pg_hba.conf]/Concat_file[/var/lib/pgsql/14/data/pg_hba.conf]: Failed to generate additional resources using 'eval_generate': uninitialized constant Puppet::Pops::Evaluator::DeferredValue
Did you mean?  Puppet::Pops::Evaluator::DeferredResolver

May want to do something like this instead:
fragment_content = r[:content].respond_to?(:resolve) ? r[:content].resolve : r[:content]

I know the metadata says this version requires Puppet 7 at least, but I think this might be the only bit that breaks Puppet 6.

Expected Behavior

Concat works correctly with pre-Puppet 7.17 agents.

@ekohl
Copy link
Collaborator

ekohl commented Jan 13, 2024

The metadata says the lower bound is Puppet 7.0.0. I don't think we'll bring back Puppet 6 support but if we claim 7.0.0, that should work. Or we should raise it.

@Ramesh7
Copy link
Contributor

Ramesh7 commented Jan 15, 2024

Thanks @nmburgan for reporting this with detailed summary as well as proposing the solution too.
Have raised internal ticket and will priorities the same.

@ekohl ekohl linked a pull request Jan 17, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants