Refactor messy CSS

[simeonf]

The problem we face is illustrated by a use case. Somebody makes a flatpage with some html in it (a header, a bulleted list, a table). However the flatpage requires a bunch of custom css rules to fix indentations, turn off styles on the table and so on. The problem is that css has been a shared commons where everybody adds custom rules to solve their problems but no designer has kept everything sane.

Even a non-designer can help us make positive progress in this area. For instance:

CSS is messy! Some suggested courses of action:

• Delete unneeded css files. I suspect we aren't using https://github.com/pybay/pybay/blob/master/static/new/css/theme-camaro.css at all eg. Confirm with grep and deleted unneeded files from this directory.
• refactor the extremely messy https://github.com/pybay/pybay/blob/master/static/new/css/styles.css - I suggest moving chunks that claim to be only for a specific page to a separate file and and including it in that page's template. This will hurt performance (specific pages request additional specific css files) but will isolate some of the crappy CSS
• Also open to defining a pre-processing step to generate .css as necessary but need a convincing explanation of the win available here.

Ping Grace if you want to work on this.

[nickdirienzo]

Thanks for taking this on @epsy! 😄

Just curious... do you know when you'll be able to put up a PR?

[epsy]

I should be able to look into it this weekend

[nickdirienzo]

Woohoo! 🎉 Thanks Yann!

…

On Thu, Mar 29, 2018, 2:59 AM Yann Kaiser ***@***.***> wrote: I should be able to look into it this weekend-- Yann Kaiser Software Engineer, Criteo ***@***.*** ***@***.*** ***@***.*** +33 6 51 64 01 89 https://github.com/epsy — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/pybay/pybay/issues/221#issuecomment-377186287>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAsKb657h2ignDh08Oet6_1qdnZFfAPmks5tjLCRgaJpZM4S2bZb> .