Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update vendored rich #13072

Open
1 task done
mgorny opened this issue Nov 9, 2024 · 2 comments · May be fixed by #13074
Open
1 task done

Please update vendored rich #13072

mgorny opened this issue Nov 9, 2024 · 2 comments · May be fixed by #13074
Labels
project: vendored dependency Related to a vendored dependency
Milestone
25.0

Comments

@mgorny
Copy link
Contributor

mgorny commented Nov 9, 2024

What's the problem this feature will solve?

pip currently vendors rich==13.7.1 which is from February. Linux distributions unvendoring pip's dependencies have long moved to newer rich versions which — as it turns out — are incompatible with pip's test suite.

Describe the solution you'd like

pip being updated for newer versions of rich.

Alternative Solutions

n/a

Additional context

n/a

Code of Conduct
@mgorny mgorny added S: needs triage Issues/PRs that need to be triaged type: feature request Request for a new feature labels Nov 9, 2024
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Nov 9, 2024
@mgorny
dev-python/rich: Restore 13.7.1 for dev-python/pip
4f5257b 
Bug: pypa/pip#13072
Signed-off-by: Michał Górny <[email protected]>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Nov 9, 2024
@mgorny
dev-python/pip: Pin to old dev-python/rich for testing
e0bf09d 
Bug: pypa/pip#13072
Signed-off-by: Michał Górny <[email protected]>
@notatallshaw
Copy link
Member

Yeah, the same thing was found while trying to update vendored libraries: #13006. Pip is a volunteer project and I don't think anyone has had time to look at why.

@notatallshaw notatallshaw added project: vendored dependency Related to a vendored dependency and removed type: feature request Request for a new feature S: needs triage Issues/PRs that need to be triaged labels Nov 9, 2024
@mgorny
Copy link
Contributor Author

mgorny commented Nov 9, 2024

Copying from the other bug:

The cause is apparently Textualize/rich@2d7a94d

mgorny added a commit to mgorny/pip that referenced this issue Nov 9, 2024
@mgorny
Override rich.console pipe handler for rich 13.8.0+
9dfadfd 
Explicitly override `rich.console.Console.on_broken_pipe()` to reraise
the original exception, to bring the behavior of rich 13.8.0+ in line
with older versions.  The new versions instead close output fds and exit
with error instead, which prevents pip's pipe handler from firing.
This is the minimal change needed to make pip's test suite pass after
upgrading vendored rich.

Bug pypa#13006
Bug pypa#13072
mgorny added a commit to mgorny/pip that referenced this issue Nov 9, 2024
@mgorny
Override rich.console pipe handler for rich 13.8.0+
8cfd050 
Explicitly override `rich.console.Console.on_broken_pipe()` to reraise
the original exception, to bring the behavior of rich 13.8.0+ in line
with older versions.  The new versions instead close output fds and exit
with error instead, which prevents pip's pipe handler from firing.
This is the minimal change needed to make pip's test suite pass after
upgrading vendored rich.

Bug pypa#13006
Bug pypa#13072
@mgorny mgorny mentioned this issue Nov 9, 2024
Merged
mgorny added a commit to mgorny/pip that referenced this issue Nov 9, 2024
@mgorny
Override rich.console pipe handler for rich 13.8.0+
3b87263 
Explicitly override `rich.console.Console.on_broken_pipe()` to reraise
the original exception, to bring the behavior of rich 13.8.0+ in line
with older versions.  The new versions instead close output fds and exit
with error instead, which prevents pip's pipe handler from firing.
This is the minimal change needed to make pip's test suite pass after
upgrading vendored rich.

Bug pypa#13006
Bug pypa#13072
mgorny added a commit to mgorny/pip that referenced this issue Nov 9, 2024
@mgorny
Override rich.console pipe handler for rich 13.8.0+
099ae97 
Explicitly override `rich.console.Console.on_broken_pipe()` to reraise
the original exception, to bring the behavior of rich 13.8.0+ in line
with older versions.  The new versions instead close output fds and exit
with error instead, which prevents pip's pipe handler from firing.
This is the minimal change needed to make pip's test suite pass after
upgrading vendored rich.

Bug pypa#13006
Bug pypa#13072
@sbidoul sbidoul added this to the 25.0 milestone Nov 9, 2024
@ichard26 ichard26 linked a pull request Nov 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project: vendored dependency Related to a vendored dependency
Projects
None yet
Milestone
25.0
Development

Successfully merging a pull request may close this issue.

Vendoring bumps for 25.0 ichard26/pip
3 participants
@mgorny @sbidoul @notatallshaw